backport: merge bitcoin#27653, #24748, #29352, #29372, #29460, #29358, #29511, #29390, #29431, bitcoin-core/gui#788 (BIP324 backports: part 4)

[kwvg]

Additional Information

• Depends on backport: merge bitcoin#20524, #26553, #27986, #28645, #28632, #28782, #28822, #29006, #29212, merge bitcoin-core/gui#754, partial bitcoin#23443, #26448 (BIP324 backports: part 3) #6329

• Dash-specific P2P messages have been allocated short IDs after 128 based on a prior suggestion (source) as there are 255 potential short IDs (ID 0 is reserved for V1 fallback, source) and upstream uses 28 short IDs (though Dash has left ID 5 blank as we do not implement the FEEFILTER message, source).

  As it is unlikely that upstream will utilize more than 127 short IDs (and the spec refers to IDs after 32 as "undefined", source), there shouldn't be an adverse effect to utilizing IDs >=128. The unified array of short IDs are accessible through V2ShortIDs().

  • As there are checks to see if an ID can be valid by checking against the array size (which wouldn't work here as we create an array of 256 entries combining both upstream and Dash's allocated short IDs, filling the rest with blank values and we cannot ignore blank values to know if a value is unallocated as the blanking could also signal a reservation, source), such a check needs to be done by using IsValidV2ShortID().
  • V2ShortIDs() isn't as elegant as desired as std::fill and std::copy are not constexpr until C++20 (source, source) and until we drop C++17 support, we have to be mindful of that.

• masternode connect will now attempt to establish a P2Pv2 connection if the node initiating the connection has opted-in using the new argument (v2transport) and the node was started with P2Pv2 enabled (using the launch argument, -v2transport).

  This mirrors changes to behavior to addconnection introduced in bitcoin#24748

• The oversized payload test in p2p_invalid_messages.py will expect an excessively large message of size of 3145729 bytes (and in P2Pv2, 3145742 bytes), as opposed to upstream's 4000001 and 4000014 bytes respectively as Dash has a lower protocol limit of 3MiB (source) vs Bitcoin's 4MB (source)

Breaking Changes

None expected.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[github-actions]

This pull request has conflicts, please rebase.

[github-actions]

This pull request has conflicts, please rebase.

[UdjinM6]

Looks good overall, will test + see few notes below

[UdjinM6]

changes looks good but needs rebase on latest develop now

[UdjinM6]

also, I tested it a bit and it seems to be working with no issues on testnet 👍

[PastaPastaPasta]

utACK 4735b82

[UdjinM6]

light ACK 4735b82