Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dashbls subtree to 1.3.2 #6310

Closed

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented Oct 4, 2024

Issue being fixed or feature implemented

bump dashbls subtree to 1.3.2

What was done?

How Has This Been Tested?

tests

Breaking Changes

n/a

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

ogabrielides and others added 4 commits October 4, 2024 18:27
3ffa7fa2b6 chore: bump version to 1.3.2 (dashpay#94)
0f4efc9327 Merge pull request dashpay#88 from HashEngineering/feat/support-android
a181889489 fix: rust bindings build for macos (dashpay#89)
69bdc1aac7 Merge pull request dashpay#85 from kwvg/debug
39791d4e31 build: print build options after configure
73106a0121 build: use `-mbranch-protection=bti` on supporting `aarch64` compilers
6a3c28f6ca build: use stricter `-Werror` when testing compile flags
7a1b227637 build: rename {`NO`}`WARN_CFLAGS` to {`NO`}`WARN_FLAGS`, use with C{++}
28bea63838 build: set {`NO`}`WARN_CFLAGS` flags if not overridden and uniformly
32c2f0f5f8 trivial: rename `CORE_CXXFLAGS` to `CORE_FLAGS`, use with C{++}
b630c2c323 build: append `HARDENED_FLAGS` to `AM_CFLAGS`
e6008148e4 trivial: rename `HARDENED_CXXFLAGS` to `HARDENED_FLAGS`
af0e3daef5 build: subsume `PI{C,E}_FLAGS` into `HARDENED_CXXFLAGS`
9ff8618a1b build: expand `--disable-optimizations` to include `-O0` and `-fwrapv`
3036b83181 build: expand `--enable-debug` to include `-O0`, `-ftrapv` and dbg info
c90d43d43b build: add check to see if `CFLAGS` has been overridden
2d77f7ae49 build: remove vestigial `LIBTOOL_{CXX,CPP,LD}FLAGS`, `HARDENED_CPPFLAGS`
883a098868 build: autodetect i?86 and arm as 32-bit
deb3269820 build: don't specify exact `{CPU_}ARCH` if optimizations are disabled
720d49a44b trivial: fix indentation for `want_backend` check
f9328320af build: use `easy` backend if optimizations are disabled unless specified
3687cd59e0 build: define new flag `--enable-optimizations`
f82bfee5dd build: ensure help string format matches Autotool defaults
d68920063e build: define arguments as `--enable-[term]` instead of `--disable-[term]`
7f41e7dd16 fix: support android
1c2fc79c19 feat(rust): allow to move G1 and G2 elements between threads (dashpay#87)
3540b8bbed feat: debug with data hex (dashpay#86)

git-subtree-dir: src/dashbls
git-subtree-split: 3ffa7fa2b62aecf3943c142508de4b7ec6005bb5
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> git reset HEAD~ --hard
HEAD is now at 52d4a838f2 Merge commit '3ae9f9d0cb65aff3a9cdb16a4845e3664189946f' into bump_bls_signatures_1.3.2
> git subtree pull -P src/dashbls dashbls main --squash
From https://github.com/dashpay/bls-signatures
 * branch                  main       -> FETCH_HEAD
Subtree is already at commit 3ffa7fa2b62aecf3943c142508de4b7ec6005bb5.

and compiles with no issues on my machine

utACK ee4c0b7

@UdjinM6 UdjinM6 added this to the 21.2 milestone Oct 4, 2024
@PastaPastaPasta
Copy link
Member

let's wait? it seems we will have a few more PRs merged in soon?

@ogabrielides
Copy link
Collaborator Author

let's wait? it seems we will have a few more PRs merged in soon?

wym? Which PRs?

@ogabrielides
Copy link
Collaborator Author

dashpay/bls-signatures#90 dashpay/bls-signatures#91 dashpay/bls-signatures#92 dashpay/bls-signatures#93

@PastaPastaPasta sure, but this PR bumps dashbls subtreee to version 1.3.2. And version 1.3.2 was already released. So... :)

@PastaPastaPasta
Copy link
Member

dashpay/bls-signatures#90 dashpay/bls-signatures#91 dashpay/bls-signatures#92 dashpay/bls-signatures#93

@PastaPastaPasta sure, but this PR bumps dashbls subtreee to version 1.3.2. And version 1.3.2 was already released. So... :)

Well 3 of those 4 PRs have been merged now :) also, what does 1.3.2 bring as far as core is concerned?

@ogabrielides
Copy link
Collaborator Author

ogabrielides commented Oct 4, 2024

@PastaPastaPasta it's your call. @UdjinM6

@ogabrielides
Copy link
Collaborator Author

won't merge.

@ogabrielides ogabrielides deleted the bump_bls_signatures_1.3.2 branch October 8, 2024 16:31
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants