refactor: segregate x11 hashing #6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
reviewed
Oct 3, 2024
src/hash_x11.h
Outdated
| return hash[10].trim256(); | ||
| } | ||
|
|
||
| #endif // BITCOIN_HASH_X11_H |
| @@ -707,6 +707,7 @@ libbitcoin_consensus_a_SOURCES = \ | |||
| consensus/validation.h \ | |||
| hash.cpp \ | |||
| hash.h \ | |||
| hash_x11.h \ | |||
There was a problem hiding this comment.
need to add hash_x11.h to test/util/data/non-backported.txt to let extra linter and clang-format run on this file
PastaPastaPasta
force-pushed
the
refactor/segregate-x11
branch
from
8fb06fe to
bd8aa04
Compare
UdjinM6
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Refactor x11 hashing out into it's own header
What was done?
move x11 hashing out of hash.h, into hash_x11.h and also move those headers crypto/x11 folder
How Has This Been Tested?
Building
Breaking Changes
None
Checklist:
Go over all the following points, and put an
xin all the boxes that apply.