fix: intermittent failures in governance tests with tsan #6216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,43 @@ | |||
| #!/usr/bin/env python3 | |||
| # Copyright (c) 2018-2024 The Dash Core developers | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2018-2024 The Dash Core developers | |
| # Copyright (c) 2024 The Dash Core developers |
There was a problem hiding this comment.
that's an old code moved from other file
UdjinM6
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Intermittent failure in functional tests feature_governance and feature_governance_cl:
and many other
What was done?
Bump timeout in
feature_governance.py,feature_governance_cl.py; moved code from them totest_framework/governance.pyHow Has This Been Tested?
Run unit/functional tests in 40 threads locally: amount of failures decreased from 50% to 2.5%
Breaking Changes
N/A
Checklist: