feat(rpc)!: remove spork active and its test, spork=spork show, update spork/sporkupdate help text
#6207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🥇 👈 for longest PR name 😉 |
UdjinM6
changed the title
spork active and its test, let spork accept anything and act like spork showspork active and its test, spork=spork show, update spork/sporkupdate help text
knst
reviewed
Aug 13, 2024
test/functional/feature_sporks.py
Outdated
| ''' | ||
| ''' | ||
|
|
||
| class SporkTest(BitcoinTestFramework): |
There was a problem hiding this comment.
so far as we do not remove Spork functionality completely, but still uses them on regtest and devnets, we should not remove this functional tests, even if that's a trivial one
UdjinM6
force-pushed
the
chore_spork_rpc
branch
from
10f77ed
to
5011916
Compare
Comment on lines
-162
to
-166
| RPCResult{"For 'active'", | ||
| RPCResult::Type::OBJ_DYN, "", "keys are the sporks, and values indicates its status", | ||
| { | ||
| {RPCResult::Type::BOOL, "SPORK_NAME", "'true' for time-based sporks if spork is active and 'false' otherwise"}, | ||
| }}, |
There was a problem hiding this comment.
dropping this param is a breaking change
PastaPastaPasta
changed the title
spork active and its test, spork=spork show, update spork/sporkupdate help textspork active and its test, spork=spork show, update spork/sporkupdate help text
|
This pull request has conflicts, please rebase. |
UdjinM6
force-pushed
the
chore_spork_rpc
branch
from
5011916
to
dbbb214
Compare
UdjinM6
force-pushed
the
chore_spork_rpc
branch
from
dbbb214
to
ba422af
Compare
UdjinM6
changed the title
spork active and its test, spork=spork show, update spork/sporkupdate help textspork active and its test, spork=spork show, update spork/sporkupdate help text
…spork` accept anything and act like `spork show`
UdjinM6
force-pushed
the
chore_spork_rpc
branch
from
ba422af
to
e1d019f
Compare
knst
approved these changes
Oct 16, 2024
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
What was done?
How Has This Been Tested?
Breaking Changes
Checklist: