Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fire up devnets by block 2 - 1/n #6187

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Aug 9, 2024

Issue being fixed or feature implemented

Many hard-forks have been delayed to block-300 on devnet to be compatible with existing devnets.

Let's make a breaking changes (for devnet) to activate everything as fast as it ready, just from block 2.

What was done?

Set activation for all buried developments on devnet at the block 2 at the latest.

How Has This Been Tested?

Run new devnet - charlie - works as expected:

  "softforks": {
    "bip34": {
      "type": "buried",
      "active": true,
      "height": 1
    },
    "bip66": {
      "type": "buried",
      "active": true,
      "height": 1
    },
    "bip65": {
      "type": "buried",
      "active": true,
      "height": 1
    },
    "bip147": {
      "type": "buried",
      "active": true,
      "height": 1
    },
    "csv": {
      "type": "buried",
      "active": true,
      "height": 1
    },
    "dip0001": {
      "type": "buried",
      "active": true,
      "height": 2
    },
    "dip0003": {
      "type": "buried",
      "active": true,
      "height": 2
    },
    "dip0008": {
      "type": "buried",
      "active": true,
      "height": 2
    },
    "dip0020": {
      "type": "buried",
      "active": true,
      "height": 2
    },
    "dip0024": {
      "type": "buried",
      "active": true,
      "height": 2
    },
    "realloc": {
      "type": "buried",
      "active": true,
      "height": 2
    },
    "v19": {
      "type": "buried",
      "active": true,
      "height": 2
    },
...

Breaking Changes

Breaking changes on devnet: all buried forks are activated at once

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 22 milestone Aug 9, 2024
@knst knst added the guix-build label Aug 9, 2024
@DashCoreAutoGuix
Copy link

Guix Automation has began to build this PR tagged as v21.0.2-devpr6187.71667ebf. A new comment will be made when the image is pushed.

@knst knst removed the guix-build label Aug 9, 2024
@DashCoreAutoGuix
Copy link

Guix Automation has completed; a release should be present here: https://github.com/dashpay/dash-dev-branches/releases/tag/v21.0.2-devpr6187.71667ebf. The image should be on dockerhub soon.

@UdjinM6
Copy link

UdjinM6 commented Aug 9, 2024

Looks good but need rebase to fix Check Merge Fast-Forward Only

@knst
Copy link
Collaborator Author

knst commented Aug 9, 2024

Looks good but need rebase to fix Check Merge Fast-Forward Only

It is testing now, I will add release notes also before it's actually ready to get merged

@knst knst changed the title feat: quick assemble of devnets by activating all hard-forks from block 2 feat: devnets are ready by block 2 Aug 9, 2024
@knst knst changed the title feat: devnets are ready by block 2 feat: fire up devnets by block 2 Aug 9, 2024
@knst knst changed the title feat: fire up devnets by block 2 feat: fire up devnets by block 2 - 1/n Aug 9, 2024
Copy link

This pull request has conflicts, please rebase.

@knst knst force-pushed the forks-speedup-devnets branch from 71667eb to cba251b Compare October 3, 2024 12:46
@knst knst requested review from UdjinM6 and PastaPastaPasta and removed request for UdjinM6 October 3, 2024 12:46
doc/release-notes-6187.md Outdated Show resolved Hide resolved
@knst knst force-pushed the forks-speedup-devnets branch from 7a29d5e to c8f7c28 Compare October 3, 2024 17:42
@knst knst requested a review from UdjinM6 October 3, 2024 20:19
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c8f7c28

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c8f7c28

@PastaPastaPasta PastaPastaPasta merged commit cf1db67 into dashpay:develop Oct 4, 2024
35 checks passed
PastaPastaPasta added a commit that referenced this pull request Dec 10, 2024
…y first block - 7/n

906c2d7 refactor: add annotation gsl::not_null for ConstructCreditPool (Konstantin Akimov)
f1905ca fix: intermittent missing of PoSe ban in feature_llmq_simplepose.py (Konstantin Akimov)
cf84dff fix: bump time for all nodes during mine_quorum in feature_llmq_rotation.py test (Konstantin Akimov)
efd4701 fix: intermittent error for feature_llmq_simplepose due to rotating quorums (Konstantin Akimov)
2bafadf feat: put DIP0024 activation to block 1 on RegTest (Konstantin Akimov)
632c4c4 feat: re-bury DIP0024 with new height when quorums actually appeared (Konstantin Akimov)
343c74b fix: intermittent error in feature_index_prune due to DKG influence (Konstantin Akimov)
de821b9 refactor: remove command line argument -bip147height, -dip8params (Konstantin Akimov)
d8ce0a7 docs: updated comment for DIP0003 activation on RegTest (Konstantin Akimov)
4dafec8 fix: add check that DIP0003 activated before retrieving CbTx for CreditPool (Konstantin Akimov)
26e9813 fix: assertion in Credit Pool validation during connecting blocks (Konstantin Akimov)

Pull request description:

  ## Issue being fixed or feature implemented
  This PR is 7th in the achieving ultimate goal to activate old forks from block 1.
  It helps to run unit and functional tests faster; it helps for platform's dev-environment to start faster.

  ## What was done?
  Prior work: #6187, #6189, #6214, #6225, #6269, #6275

  This PR:
   - simplify DIP0024 activation and activate it from block 1 at RegTest
   - removes command lines arguments: -bip147height, -dip8params
   - fixed intermittent errors in feature_index_prune.py and feature_llmq_simplepose.py
   - fix assertion crash on Regtest if using strange combination of -testactivationheight and -dip3params

  ## How Has This Been Tested?
  Run unit, functional tests.

  ## Breaking Changes
  [regtest only] -dip8params, -bip147height are removed.

  ## Checklist:
  - [x] I have performed a self-review of my own code
  - [x] I have commented my code, particularly in hard-to-understand areas
  - [x] I have added or updated relevant unit/integration/functional/e2e tests
  - [x] I have made corresponding changes to the documentation
  - [x] I have assigned this pull request to a milestone

ACKs for top commit:
  UdjinM6:
    utACK 906c2d7
  PastaPastaPasta:
    utACK 906c2d7

Tree-SHA512: fab8a9bc03bb7f220c19dd952a03f8fec0b6ef1362d7308eb77c90e0ba814a241bb2bf36beccf78bb285ede1b6d85ec52fa19b3729ac9b643b420d13fbb63b47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants