feat: keep llmq_50_60 enabled in Devnets #6183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knst
reviewed
Aug 9, 2024
knst
previously approved these changes
Aug 9, 2024
5 tasks
ogabrielides
changed the title
PastaPastaPasta
requested changes
Aug 20, 2024
PastaPastaPasta
added a commit
that referenced
this pull request
Sep 25, 2024
32ef5f8 chore: bump version in core to v22 (pasta) Pull request description: ## Issue being fixed or feature implemented Platform is requesting #6183 be merged into develop, so that they can stop using hacky custom builds (which end up being out of date). ## What was done? Bump version to v22.0, allow for breaking changes to be merged in. My plan here is to basically have v22.0 be what v21.1 would have originally been, a large minor version, however now, we can merge in breaking changes too. Breaking changes can now be merged in I don't have a firm timeline yet, but I want this optional smaller v22 to be released relatively quickly compared to normal major versions. ## How Has This Been Tested? NA ## Breaking Changes None, yet! ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: knst: utACK 32ef5f8 UdjinM6: utACK 32ef5f8 Tree-SHA512: 5695c076f4fc5666300492f734dd1ef860a6c7cbbfc7647dfb998c6a2188fddbe69f11c38b8f26b82d6711ef0ccb19d64cf2f6768035800f74120aa271eed4ad
|
@ogabrielides can you add release notes and rebase? |
ogabrielides
force-pushed
the
enable_50_60_devnet
branch
from
a95aaf1 to
de4238e
Compare
|
@PastaPastaPasta done |
knst
previously approved these changes
Oct 3, 2024
|
Clang format complains: --- src/llmq/options.cpp (before formatting)
+++ src/llmq/options.cpp (after formatting)
@@ -[13](https://github.com/dashpay/dash/actions/runs/11082690782/job/30796045092?pr=6183#step:4:14)1,8 +131,8 @@
case Consensus::LLMQType::LLMQ_DEVNET:
return true;
case Consensus::LLMQType::LLMQ_50_60:
- return !fDIP0024IsActive || !fHaveDIP0024Quorums ||
- Params().NetworkIDString() == CBaseChainParams::TESTNET || Params().NetworkIDString() == CBaseChainParams::DEVNET;
+ return !fDIP0024IsActive || !fHaveDIP0024Quorums || Params().NetworkIDString() == CBaseChainParams::TESTNET ||
+ Params().NetworkIDString() == CBaseChainParams::DEVNET;
case Consensus::LLMQType::LLMQ_TEST_INSTANTSEND:
return !fDIP00[24](https://github.com/dashpay/dash/actions/runs/11082690782/job/30796045092?pr=6183#step:4:25)IsActive || !fHaveDIP0024Quorums ||
consensusParams.llmqTypeDIP0024InstantSend == Consensus::LLMQType::LLMQ_TEST_INSTANTSEND; |
|
@UdjinM6 done. |
UdjinM6
approved these changes
Oct 3, 2024
knst
approved these changes
Oct 3, 2024
PastaPastaPasta
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
LLMQ_50_60 needs to be enabled in Devnets when deploying a larger one.
What was done?
How Has This Been Tested?
Breaking Changes
no
Checklist: