fix: optimize compilation time of gsl library #6039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
This header
gsl/pointers.h
is included in multiple other headers all over codebase.Any extra line of code inside gsl/pointers.h makes all project to compile slower.
What was done?
Removed headers
<algorithm>
,<system_error>
,<iosfwd>
from gsl/pointers.hHow Has This Been Tested?
Run command 5 times, takes minimum time:
as a result, overall project compilation time is also improved:
make clean ; sleep 3s ; time make -j20
Breaking Changes
N/A
Checklist: