feat: add container resource detector by default

dash0hq · Jun 10, 2024 · 708888f · 708888f
1 parent a544e24
commit 708888f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -45,6 +45,7 @@
     "@opentelemetry/auto-instrumentations-node": "^0.44.0",
     "@opentelemetry/exporter-metrics-otlp-proto": "^0.51.0",
     "@opentelemetry/exporter-trace-otlp-proto": "^0.51.0",
+    "@opentelemetry/resource-detector-container": "^0.3.11",
     "@opentelemetry/sdk-metrics": "^1.24.0",
     "@opentelemetry/sdk-node": "^0.51.0",
     "@opentelemetry/sdk-trace-node": "^1.24.0"

diff --git a/src/init.ts b/src/init.ts
@@ -7,6 +7,7 @@ import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-proto';
 import { Detector, DetectorSync, envDetector, hostDetector, processDetector, Resource } from '@opentelemetry/resources';
 import { PeriodicExportingMetricReader } from '@opentelemetry/sdk-metrics';
 import { NodeSDK, NodeSDKConfiguration } from '@opentelemetry/sdk-node';
+import { containerDetector } from '@opentelemetry/resource-detector-container';
 
 import { version } from '../package.json';
 import PodUidDetector from './detectors/node/opentelemetry-resource-detector-kubernetes-pod';
@@ -55,7 +56,7 @@ let detectors: (Detector | DetectorSync)[];
 if (process.env.OTEL_NODE_RESOURCE_DETECTORS != null) {
   detectors = getResourceDetectors();
 } else {
-  detectors = [envDetector, processDetector, hostDetector];
+  detectors = [envDetector, processDetector, containerDetector, hostDetector];
 }
 detectors.push(new PodUidDetector());
 detectors.push(new ServiceNameFallbackDetector());