-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Fix MatrixRef::lbegin/lend #428
base: development
Are you sure you want to change the base?
Conversation
The offsets are still broken and I cannot seem to figure out which offsets to use. Will look at it again tomorrow... Any help is appreciated, though. |
@fuchsto I'm giving up here as it is not clear to me anymore which are global and local block coordinates and indexes. Also, I suspect that there are fixes lingering around in your branches. I'd appreciate a timely merge or a quick fix as the broken |
This PR was my attempt to fix |
This PR fixes two issues with
MatrixRef
lbegin
/lend
:lend()
inLocalMatrixRef
(and thusMatrixRef
) to not return anullptr
but a pointer past the end of the range (GlobViewIter::local()
returnsnullptr
if pointing beyond the current unit)