Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout git submodule if it was not done before #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bjoe
Copy link
Contributor

@Bjoe Bjoe commented Nov 9, 2018

It's nice to have. I'm every time clone the projects without --recursive, because some project checkout like the "whole world" ;-) ... so I'm carfully with --recusive.
But it gets some weird cmake errors when neopg is not checkout with --recursive.
It`s nice to have a submodule checkout from cmake if anyone forgot it :-)

@Bjoe Bjoe mentioned this pull request Nov 9, 2018
@lambdafu
Copy link
Collaborator

lambdafu commented Nov 9, 2018

To be honest, I hate submodules anyway. Maybe we should copy. I'll revisit what we need them for right now.

@Bjoe
Copy link
Contributor Author

Bjoe commented Nov 10, 2018

To be honest, I hate submodules anyway.

Yep, me too! :-) .... I have also for that a suggestion ... but it is still in testing/develop. Hopefully in the end of November I can give you a quick working version and you can decide if you want it or not....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants