Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource identifiers to package:messages #844

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented May 28, 2024

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@mosuem mosuem changed the base branch from main to adaptToResourcesIdentifier May 28, 2024 15:47
@mosuem mosuem changed the base branch from adaptToResourcesIdentifier to adaptMessagesExample May 28, 2024 15:47
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:intl4x 0.9.0 ready to publish intl4x-v0.9.0
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl_translation 0.20.0 already published at pub.dev
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

PR Health

Breaking changes ⚠️

Details
Package Change Current Version New Version Needed Version Looking good?
messages Breaking 0.2.0 0.2.0 0.3.0
Got "0.2.0" expected >= "0.3.0" (breaking changes)
⚠️
messages_builder Breaking 0.2.1 0.2.1 0.3.0
Got "0.2.1" expected >= "0.3.0" (breaking changes)
⚠️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ❗

Details
Package Changed Files
package:messages pkgs/messages/example_json/pubspec.yaml
pkgs/messages/pubspec.yaml
package:messages_builder pkgs/messages_builder/lib/code_generation/class_generation.dart
pkgs/messages_builder/lib/code_generation/import_generation.dart
pkgs/messages_builder/lib/code_generation/method_generation.dart

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️

Details
File Coverage
pkgs/messages/example_json/bin/example.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/class_generation.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/import_generation.dart 💔 Not covered
pkgs/messages_builder/lib/code_generation/method_generation.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/messages_builder/lib/hook.dart

Package publish validation ✔️

Details
Package Version Status
package:intl4x 0.9.0 ready to publish
package:intl 0.20.0-wip WIP (no publish necessary)
package:intl_translation 0.20.0 already published at pub.dev
package:messages 0.2.0 already published at pub.dev
package:messages_builder 0.2.1 already published at pub.dev
package:messages_serializer 0.2.1 already published at pub.dev
package:messages_shrinker 0.2.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem force-pushed the adaptMessagesExample branch 3 times, most recently from 38ac02d to 1dc22c0 Compare July 29, 2024 14:13
Base automatically changed from adaptMessagesExample to main October 31, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant