refactor: make gossip_arc_clamp and explicit setting, rather than specifying via features flags #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump holonix to have tests pass
…cifying via features flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #31 I added feature flags to set the gossip arc clamping.
In practice I accidentally forgot to set the feature flags and never noticed. It feels like a weird inconsistent approach, since all other conductor settings passed in are set in the
HolochainPluginConfig.This moves the gossip arc clamping setting into the
HolochainPluginConfigand requires it be explicitly set. The default behavior is no gossip arc clamping.If needed, a dev can still set their own feature flag which conditionally changes the
HolochainPluginConfigvalue, which feels more explicit and obvious.