Fix some problems within brute_tlds function #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest version on master tests only all combination of {basename}.{cc}.{tld}, but not the single {basename}.{cc} or {basename}.{tld}.
Furthermore, most of the {cc}.{tld} are not valid combos, so there is a big wast of time.
I suggest to download the list taken from https://publicsuffix.org/, which is a complete and maintained list of all the possibile tlds.
|
Can you run ruff format please |
|
Sorry @L1ghtn1ng, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version on master tests only all combination of {basename}.{cc}.{tld}, but not the single {basename}.{cc} or {basename}.{tld}. Furthermore, most of the {cc}.{tld} are not valid combos, so there is a big wast of time. I suggest to download the list taken from https://publicsuffix.org/, which is a complete and maintained list of all the possibile tlds.