Added error handling on underflowed liquidity

darkforestry · May 1, 2023 · b910988 · b910988
1 parent 986abb8
commit b910988
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/amm/uniswap_v3/mod.rs b/src/amm/uniswap_v3/mod.rs
@@ -273,7 +273,11 @@ impl AutomatedMarketMaker for UniswapV3Pool {
                     }
 
                     current_state.liquidity = if liquidity_net < 0 {
-                        current_state.liquidity - (-liquidity_net as u128)
+                        if current_state.liquidity < (-liquidity_net as u128) {
+                            return Err(SwapSimulationError::LiquidityUnderflow);
+                        } else {
+                            current_state.liquidity - (-liquidity_net as u128)
+                        }
                     } else {
                         current_state.liquidity + (liquidity_net as u128)
                     };
@@ -398,7 +402,11 @@ impl AutomatedMarketMaker for UniswapV3Pool {
                     }
 
                     current_state.liquidity = if liquidity_net < 0 {
-                        current_state.liquidity - (-liquidity_net as u128)
+                        if current_state.liquidity < (-liquidity_net as u128) {
+                            return Err(SwapSimulationError::LiquidityUnderflow);
+                        } else {
+                            current_state.liquidity - (-liquidity_net as u128)
+                        }
                     } else {
                         current_state.liquidity + (liquidity_net as u128)
                     };

diff --git a/src/errors.rs b/src/errors.rs
@@ -82,4 +82,6 @@ pub enum SwapSimulationError {
     InvalidTick,
     #[error("Uniswap v3 math error")]
     UniswapV3MathError(#[from] UniswapV3MathError),
+    #[error("Liquidity underflow")]
+    LiquidityUnderflow,
 }