Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows support reuse id policy #637

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

famarting
Copy link
Contributor

Description

Implements the missing bits to support workflows reuse id policy

Issue reference

Please reference the issue this PR will close: #493

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

Signed-off-by: Fabian Martinez <[email protected]>
@famarting famarting requested review from a team as code owners October 11, 2024 11:39
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 15 lines in your changes missing coverage. Please review.

Project coverage is 62.43%. Comparing base (27248ba) to head (df1f482).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
workflow/state.go 40.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   58.04%   62.43%   +4.39%     
==========================================
  Files          55       56       +1     
  Lines        3568     4169     +601     
==========================================
+ Hits         2071     2603     +532     
- Misses       1375     1440      +65     
- Partials      122      126       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think surfacing this struct as an option is quite confusing in its current form, could the function possibly be refactored to not require another (internal) struct from microsoft/durabletask-go and/or document this before merge?

Signed-off-by: Fabian Martinez <[email protected]>
Signed-off-by: Fabian Martinez <[email protected]>
@famarting
Copy link
Contributor Author

I think surfacing this struct as an option is quite confusing in its current form, could the function possibly be refactored to not require another (internal) struct from microsoft/durabletask-go and/or document this before merge?

done

@mikeee mikeee self-requested a review October 15, 2024 08:16
Comment on lines 35 to 36
OperationStatus []api.OrchestrationStatus
Action api.CreateOrchestrationAction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these types be defined/wrapped as part of the go-sdk and parsed in the options function below?

Signed-off-by: Fabian Martinez <[email protected]>
@famarting famarting requested a review from mikeee October 21, 2024 14:53
Signed-off-by: Fabian Martinez <[email protected]>
@famarting
Copy link
Contributor Author

merge please

@yaron2 yaron2 merged commit 4953b12 into dapr:main Oct 30, 2024
18 of 19 checks passed
@famarting famarting deleted the wf-support-reuseid branch October 31, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support workflow ID reuse policy
3 participants