-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows support reuse id policy #637
Conversation
Signed-off-by: Fabian Martinez <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #637 +/- ##
==========================================
+ Coverage 58.04% 62.43% +4.39%
==========================================
Files 55 56 +1
Lines 3568 4169 +601
==========================================
+ Hits 2071 2603 +532
- Misses 1375 1440 +65
- Partials 122 126 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think surfacing this struct as an option is quite confusing in its current form, could the function possibly be refactored to not require another (internal) struct from microsoft/durabletask-go
and/or document this before merge?
Signed-off-by: Fabian Martinez <[email protected]>
b9824f1
to
be78592
Compare
Signed-off-by: Fabian Martinez <[email protected]>
done |
workflow/client.go
Outdated
OperationStatus []api.OrchestrationStatus | ||
Action api.CreateOrchestrationAction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could these types be defined/wrapped as part of the go-sdk and parsed in the options function below?
Signed-off-by: Fabian Martinez <[email protected]>
52b281d
to
739b448
Compare
Signed-off-by: Fabian Martinez <[email protected]>
merge please |
Description
Implements the missing bits to support workflows reuse id policy
Issue reference
Please reference the issue this PR will close: #493
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: