-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement workflow management #476
Conversation
Signed-off-by: mikeee <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 68.96% 72.22% +3.25%
==========================================
Files 34 36 +2
Lines 2707 3143 +436
==========================================
+ Hits 1867 2270 +403
- Misses 732 754 +22
- Partials 108 119 +11 ☔ View full report in Codecov by Sentry. |
cc @cgillum |
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Thanks for picking up the review here @RyanLettieri |
client/workflow_test.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One test case I would like to see is passing in an input to the start workflow calls. In other SDKs we've run into an issue where certain input types would lead to an error since they couldn't be parsed correctly. For example, in .NET we needed to serialize the data and convert it into a bytestring. It may not be an issue in GO, but having the test coverage can't hurt.
b834f30
to
55a388e
Compare
Signed-off-by: mikeee <[email protected]>
55a388e
to
99c2747
Compare
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Merging these commits into #487 |
[WIP]
Implements Workflow management (Alpha + Beta endpoints).
E2E testing is not yet implemented as Authoring is still outstanding.
This does not yet fully close this issue: #379 as authoring is not included in this PR.
Contributes towards the completion of dapr/dapr#7156