feat: add golangci-lint (local) version check #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 68.96% 68.96%
=======================================
Files 34 34
Lines 2707 2707
=======================================
Hits 1867 1867
Misses 732 732
Partials 108 108 ☔ View full report in Codecov by Sentry. |
mikeee
force-pushed
the
mikeee-golangci-lint-verify-version
branch
from
1e63f0f to
8a582ab
Compare
Add golangci-lint version check to compare the local version against the workflow version. Adds associated test workflow for mac, ubuntu and windows. Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
mikeee
force-pushed
the
mikeee-golangci-lint-verify-version
branch
from
cd551f3 to
6dea596
Compare
Signed-off-by: mikeee <[email protected]>
yaron2
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check golangci-lint version using a go script (launched using
make lint)Ref:
This PR closes #454