Enhance workFlow to add go mod tidy #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kruthika04 <[email protected]>
mukundansundar
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
LGTM.
Thanks for the contribution !!
Consider adding modtidy-all for checking examples also? @yaron2 @dapr/maintainers-go-sdk thoughts?
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 34 34
Lines 2735 2735
=======================================
Hits 1892 1892
Misses 734 734
Partials 109 109 ☔ View full report in Codecov by Sentry. |
ItalyPaleAle
approved these changes
Sep 22, 2023
sicoyle
approved these changes
Sep 22, 2023
Can you please add @kruthika04 ? |
yaron2
approved these changes
Sep 22, 2023
|
Thank you for your contribution! |
mikeee
pushed a commit
to mikeee/dapr_go-sdk
that referenced
this pull request
Sep 26, 2023
Signed-off-by: kruthika04 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #450
Added job to ccheck for if the go mod needs updating when we create pull requests