Skip events scanners if tx receipt not found #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3alpha
reviewed
Dec 20, 2024
| @@ -70,6 +74,17 @@ func (ds *DistributionLogUpdatedEventScanner) runScan(ctx context.Context) { | |||
| return | |||
| } | |||
|
|
|||
| // Skip if tx receipt not found (nil). This means that the node does not store log receipts and there are no logs at all | |||
| receipt, err := ds.executionPort.GetTransactionReceipt(ds.csModuleTxReceipt) | |||
There was a problem hiding this comment.
I would abstract this querying into another function that just returns true or false, so it can be used both here and in validator exit requests. That way it would be tidier and we could make it to be more robust in determining status. At first look it may look unusual why that exact tx receipt is being queried.
Also, we shouldn't assume how different execution clients respond and we need to test that. We know that Reth responses with result: null but we need to see how Erigon responds and handle it appropriately.
3alpha
approved these changes
Dec 23, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip events scanners if tx receipt not found. This will prevent from getting false positives when queriying the ETH rpc
eth_getLogs. Also notify the user in ejector scanner due to its criticallity