Skip to content

Commit

Permalink
Fixed link in README and updated CONTRIBUTING (microsoft#517)
Browse files Browse the repository at this point in the history
* Fixed link in README
* Updated CONTRIBUTING guide
* Removed dead link
  • Loading branch information
fnocera authored Feb 11, 2021
1 parent 3185ec5 commit 972f488
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 10 deletions.
14 changes: 6 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ to the project's Contributors group. Please contact one of the project's
administrators to be added to the group.
You will still need a PR against master in order to merge your changes.

## How to contribute

When you have an idea for contribution open an *issue*!

More details can be found in the internal CSE Wiki under the page `Contributing_to_the_Code-With_Engineering_Playbook`.

## Git guidance

Consistent with the practices suggested in this playbook, please follow the
Expand Down Expand Up @@ -95,12 +101,6 @@ Each section consist of the following parts
1. Tool specific implementations of the concept
2. Named patterns or games that implement the concept (usually applies to
agile ceremonies)
4. Case Studies
1. Examples that illustrate how a team implemented the concept
2. What problem was the team try to solve with their implementation?
3. What worked well?
4. Opportunities for improvement
5. External Reference Material

### Example Directory Hierarchy

Expand All @@ -120,8 +120,6 @@ The following illustrates how the directory structure could be organized.
- ci-pipeline-for-dotnet-core.md
- ci-pipeline-for-python.md
- /jenkins
- /case-studies
- contoso-ci-pipeline-for-terraform.md
```

## Legal Notices
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ A [breakdown of sections](SPRINT-STRUCTURE.md) according to the structure of an

## QuickLinks

* [Engineering Fundamentals Checklist](Engineering Fundamentals Checklist.md)
* [Engineering Fundamentals Checklist](ENG-FUNDAMENTALS-CHECKLIST.md)
* [Structure of a Sprint](SPRINT-STRUCTURE.md)

## Engineering Fundamentals
Expand Down
1 change: 0 additions & 1 deletion observability/tools/loki.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,3 @@ of the log itself, using less space than just storing the raw logs.
- [Inserting logs into Loki](https://grafana.com/docs/loki/latest/getting-started/get-logs-into-loki/)
- [Adding Loki Source to Grafana](https://grafana.com/docs/grafana/latest/datasources/loki/#adding-the-data-source)
- [Comparing Loki to other log systems](https://grafana.com/docs/loki/latest/overview/comparisons/)
- [Loki Best Practices](https://grafana.com/docs/loki/latest/best-practices/current-best-practices/)

0 comments on commit 972f488

Please sign in to comment.