Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3connect/burnerwallet #1353

Merged
merged 18 commits into from
Feb 3, 2020
Merged

Conversation

dkent600
Copy link
Contributor

@dkent600 dkent600 commented Jan 31, 2020

Resolves: #1342
Resolves: #1320

Upgrade latest Web3Connect and add the BurnerWallet provider.

  • new behavior: when the user changes the account in MM they are completely logged off in Alchemy and the cached account info is deleted (before we only reinitiatlized Arc)
  • the latest Web3Connect replaces our provider caching code with their own

@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-6c47wb January 31, 2020 16:02 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 16:19 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 18:09 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 18:12 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 19:01 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 19:03 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 19:45 Inactive
src/arc.ts Outdated

export function getCachedAccount(): Address | null {
return localStorage.getItem(ACCOUNT_STORAGEKEY);
}export interface IEnableWalletProviderParams {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/arc.ts Outdated
@@ -295,23 +343,23 @@ function inTesting(): boolean {
/**
* Prompt user to select a web3Provider and enable their account.
* Initializes Arc with the newly-selected web3Provider.
* Is a no-op if already done.
* No-op if `selectedProvider` is already set (one can manuallygo to readonly mode to clear it)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manually go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 21:59 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 22:21 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx January 31, 2020 23:15 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx February 1, 2020 14:47 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx February 2, 2020 12:57 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx February 2, 2020 16:47 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx February 2, 2020 17:07 Inactive
@jellegerbrandy jellegerbrandy temporarily deployed to alchemy-web3connect-bur-muxftx February 2, 2020 17:12 Inactive
@jellegerbrandy jellegerbrandy merged commit 8f0e39f into competition Feb 3, 2020
jellegerbrandy added a commit that referenced this pull request Feb 10, 2020
* update docker-compose

* get rid of floats and margins for positioning in card

* hook up to actual executed Competition proposals

* work-around out-of-memory in webpack.dev.server

* complete details html

* upgrade subgraph version

* fixed solutions row css

* improvements to Card

* more Card improvements

* StatusBlob, css, links to client, tz datetimes

* more in Details

* implement create solution action

* better solutions table css

* blue border on selected solution

* more on solution details, other css

* a little more niceness in Details

* connected solution vote to client lib

* new proposal expectation text

* more proposal expectation text

* Solution => Suggestion

* more Solution=> Submission

* add spacing between cards

* UI improvements and bug fixes for submshn details

* more layout improvements

* cleanup up schemeContainer layout a bit

* pull in latest client lib

* refactor suggestions queries, get splits

* show user voted in details

* detect whether current user voted in Subm Details

* fix title and description on create

* fix hang on competitions having 0 submissions

* fix time options

* ui taeaks, added Redeem

* avoid clipping of user account popup

* Alter logic for showing voting countdown

* clean up schemecontainer layout

* refactor modularity pattern

* add Go To Competition link to ProposalDetails

* supply dynamic crx contract name in utils

* refactor to get crx rewarder name synchronously

* a little cleanup refactoring

* lint

* scroll bars for create proposal modal

* remove obsolete comment

* fix suggestor account profile

* fix breadcrumbs

* fix breadcrumbs

* fix display of voting countdown

* fix card clipping on bottom with very long title

* spacing tweak

* add date picker

* fix date picker

* add time picker

* update competion proposal validation

* submission details from url

* fix createproposal lint errors

* use client 0.2.39

* fix reward split validation

* update date-time picker

* remove console log

* tweaks to date picker layout

* use client 0.2.40

* handle no submissions, css tweaks

* enable use of proposal.scheme

* update addresses, use latests test_env images

* support for displaying submission tags

* fix compile error, nowrap account names

* add voting period countdown

* fix huge url layout problem

* fix validation error not showing

* Rename inputs

* add some more date time validations

* fix lint error

* no-winners text, auto update UI on phase changes

* fix no winners text

* add submissions to start countdown

* to redeem, check if proposal is redeemed

* use cleint 0.2.41

* start on winning voters

* tweak creator css

* more for isWinner

* more on votes

* show competition end datetime in card

* winners feedback on cards

* lint

* use latest test_env images

* fix dependency error

* better subscriptions, little tweaks

* refactor utils.getSubmissions

* new subgraph, more refactoring, fixes, changes

* status changes

* reenable tags

* add CompetitionVote.search by competition

* variable name correction

* fix compile error

* try for fixing repfromtoken

* fix rep redeem for privateKey case

* fix submission creator account

* fix thumbsup icon tooltip

* fix compile error

* add needed subscriptions for SubDetails

* fix bug that crashes competition page

* fix compile error

* update test code

* make staging code build not run out of memory

* nicer vote button

* automatically update status in SubmissionDetails

* fix compile error

* show competition regardless of passed or executed

* restrict redeem button just on GP redemptions

* fix compile error

* handle no logged-in account

* gate new submissions until proposal is executed

* xperiment

* another try to fix wrap

* clean up subdetails layout a little when sparse

* show countdown when inbetween subm and voting

* fix submission row corner styling

* better wrapping on rep in right section

* upgrade to client 2.44

* fix submissions query

* use masterrinkeby

* add scrollbar to description

* replaced datepicker

* comp start time should be shown as required

* try at test fix

* css fixes

* fix automated test

* show rep as percentage

* first phase of Competition card sorting

* more efficient fetching of status by Cards

* removed lint disably thing

* a little code cleanup

* sort tied cards by stage dates

* add CountdownText component

* fix package errors that break the build

* merge dev

* a couple requested text changes

* countdown styling

* status tracking issues, refactor account votes

* subm created date.  triangle for current phase

* more improvements to status logic

* max width of images in subscription descriptions

* start on createproposal mobility

* use grid css to align in createproposal modal

* tweak CreateProposal CSS

* more mobile

* use fr units

* start on switching submissions list to grid

* remove comments, lint warnings

* start on mobile detais/submissions

* undo false start

* more mobility in details

* fix compile error

* upgrade client to latest migration

* update ganache subgraph

* use vote.submission

* capture votes.  proposerIsAdmin, customBeneficiary

* remove comments

* mobilize the submissions list

* SubmissionDetails mobility

* merge add'l dev change

* better bluebuttons

* more submissionDetal mobility

* mobilize create submission modal

* wording change

* no scroll description when no submissions

* the merge fixes that I forgot to commit earlier

* new datetime calendar

* fix tests ( :-D !)

* IStateProps=>IState

* IExternalStateProps=>IExternalState

* classname import

* added comments

* cleanup changelog.md

* add braces

* statusblob comment

* removed comments

* more changelog

* fixing mixpanel base url passing

* fix mixpanel problems (hopefully)

* undo changes that should not have been committed

* lint

* add comment in moment-timezone

* show beneficiary instead of suggester

* Fix staking errors

Get staking working
Make sure error doesnt overlap amount needed to boost text

Fixes: #1350

* mobile glitch at bottom of subm det on iPhone 5

* mobiliity tweaks

* restore submission details url

* add disqus to submission details (#1358)

* add disqus to submission details
* use submission, not proposal, title

* web3connect/burnerwallet (#1353)

* forgot to commit package.json

* validate for invalid datetime formatting

* add disqus to CompetitionDetails

* xdai support (#1372)

* tweaks to help disqus

* remove disqus from submission details

* nicer formating on submissions heading

* tweak width of winners badge

* tweak redeem button

* fix xdai settings

* fix mainnet connection identifier

* start on high-level caching

* supress build dev errors

* set correct xdai endpoints

* optimize getSubmission

* optimize getCompetitionVotes

* more preparation of queries for caching

* removed redundant code

* upgrade xdao subgraph to v37_3_xdai

* added a comment

* upgrade burnerwallet

* When on xdai network ETH becomes xDAI and GEN becomes xGEN (#1380)

* show only registred daos in xdai network

* new xDao subgraph

* fix tokens.json for production

* lint

* disable new submission button and show tooltip

* add torus web provider

* prevent new submission click when disabled

* undo add Torus

* switch to absolute rep from percentage

* fix compile errors

Co-authored-by: Doug Kent <[email protected]>
Co-authored-by: Shivani <[email protected]>
Co-authored-by: Tibet Sprague <[email protected]>
jellegerbrandy added a commit that referenced this pull request Feb 11, 2020
* upgarde client to 0.2.57

* update subgraph endpoints

* Remove unused multi-codec package (#1379)

* Remove unused multi-codec package

* update wdio to work with latest Chrome

* upgrade to client 0.2.58 (#1381)

this includes the "retry on network error" fix for graphql queries.

* Make sure you can always see the whole create proposal form (#1387)

If screen is too small then allow for scrolling the form content
Also add a close button to the header to make it easier to always get out, especially on mobile

Fixes #1378

* use client 0.2.59 (#1395)

* use client 0.2.59
* fix proposal-competition test
* prive ntwork addresses of ens contracts

* Interestingly, setting devtool to source-maps on prod makes the bundle smaller. (#1401)

The gzipped app bundle goes from 155GB to 114KB!
I'm not sure what the default is that it was using before, must have been some inline source maps, so this is better.  And we get to keep source maps on production for debugging

* Fix warning about ProposalCard memory leak (#1400)

Fixes #1374

* Improve layout of redemptions page header (#1399)

* Update # rep to redeem from tokens when switching account (#1394)

* Update # rep to redeem from tokens when switching account

Also attempt to set to 0 after redeem succeeds, but hard to do this with current client library, see daostack/arc.js#412

* Disable redeem buttons if 0 rep to redeem

Fixes: #1319

* nice accountProfile loading message (#1398)

* DAOcreator Embed (#1264)

* Competition improvementx, xdai support (#1362)

* update docker-compose

* get rid of floats and margins for positioning in card

* hook up to actual executed Competition proposals

* work-around out-of-memory in webpack.dev.server

* complete details html

* upgrade subgraph version

* fixed solutions row css

* improvements to Card

* more Card improvements

* StatusBlob, css, links to client, tz datetimes

* more in Details

* implement create solution action

* better solutions table css

* blue border on selected solution

* more on solution details, other css

* a little more niceness in Details

* connected solution vote to client lib

* new proposal expectation text

* more proposal expectation text

* Solution => Suggestion

* more Solution=> Submission

* add spacing between cards

* UI improvements and bug fixes for submshn details

* more layout improvements

* cleanup up schemeContainer layout a bit

* pull in latest client lib

* refactor suggestions queries, get splits

* show user voted in details

* detect whether current user voted in Subm Details

* fix title and description on create

* fix hang on competitions having 0 submissions

* fix time options

* ui taeaks, added Redeem

* avoid clipping of user account popup

* Alter logic for showing voting countdown

* clean up schemecontainer layout

* refactor modularity pattern

* add Go To Competition link to ProposalDetails

* supply dynamic crx contract name in utils

* refactor to get crx rewarder name synchronously

* a little cleanup refactoring

* lint

* scroll bars for create proposal modal

* remove obsolete comment

* fix suggestor account profile

* fix breadcrumbs

* fix breadcrumbs

* fix display of voting countdown

* fix card clipping on bottom with very long title

* spacing tweak

* add date picker

* fix date picker

* add time picker

* update competion proposal validation

* submission details from url

* fix createproposal lint errors

* use client 0.2.39

* fix reward split validation

* update date-time picker

* remove console log

* tweaks to date picker layout

* use client 0.2.40

* handle no submissions, css tweaks

* enable use of proposal.scheme

* update addresses, use latests test_env images

* support for displaying submission tags

* fix compile error, nowrap account names

* add voting period countdown

* fix huge url layout problem

* fix validation error not showing

* Rename inputs

* add some more date time validations

* fix lint error

* no-winners text, auto update UI on phase changes

* fix no winners text

* add submissions to start countdown

* to redeem, check if proposal is redeemed

* use cleint 0.2.41

* start on winning voters

* tweak creator css

* more for isWinner

* more on votes

* show competition end datetime in card

* winners feedback on cards

* lint

* use latest test_env images

* fix dependency error

* better subscriptions, little tweaks

* refactor utils.getSubmissions

* new subgraph, more refactoring, fixes, changes

* status changes

* reenable tags

* add CompetitionVote.search by competition

* variable name correction

* fix compile error

* try for fixing repfromtoken

* fix rep redeem for privateKey case

* fix submission creator account

* fix thumbsup icon tooltip

* fix compile error

* add needed subscriptions for SubDetails

* fix bug that crashes competition page

* fix compile error

* update test code

* make staging code build not run out of memory

* nicer vote button

* automatically update status in SubmissionDetails

* fix compile error

* show competition regardless of passed or executed

* restrict redeem button just on GP redemptions

* fix compile error

* handle no logged-in account

* gate new submissions until proposal is executed

* xperiment

* another try to fix wrap

* clean up subdetails layout a little when sparse

* show countdown when inbetween subm and voting

* fix submission row corner styling

* better wrapping on rep in right section

* upgrade to client 2.44

* fix submissions query

* use masterrinkeby

* add scrollbar to description

* replaced datepicker

* comp start time should be shown as required

* try at test fix

* css fixes

* fix automated test

* show rep as percentage

* first phase of Competition card sorting

* more efficient fetching of status by Cards

* removed lint disably thing

* a little code cleanup

* sort tied cards by stage dates

* add CountdownText component

* fix package errors that break the build

* merge dev

* a couple requested text changes

* countdown styling

* status tracking issues, refactor account votes

* subm created date.  triangle for current phase

* more improvements to status logic

* max width of images in subscription descriptions

* start on createproposal mobility

* use grid css to align in createproposal modal

* tweak CreateProposal CSS

* more mobile

* use fr units

* start on switching submissions list to grid

* remove comments, lint warnings

* start on mobile detais/submissions

* undo false start

* more mobility in details

* fix compile error

* upgrade client to latest migration

* update ganache subgraph

* use vote.submission

* capture votes.  proposerIsAdmin, customBeneficiary

* remove comments

* mobilize the submissions list

* SubmissionDetails mobility

* merge add'l dev change

* better bluebuttons

* more submissionDetal mobility

* mobilize create submission modal

* wording change

* no scroll description when no submissions

* the merge fixes that I forgot to commit earlier

* new datetime calendar

* fix tests ( :-D !)

* IStateProps=>IState

* IExternalStateProps=>IExternalState

* classname import

* added comments

* cleanup changelog.md

* add braces

* statusblob comment

* removed comments

* more changelog

* fixing mixpanel base url passing

* fix mixpanel problems (hopefully)

* undo changes that should not have been committed

* lint

* add comment in moment-timezone

* show beneficiary instead of suggester

* Fix staking errors

Get staking working
Make sure error doesnt overlap amount needed to boost text

Fixes: #1350

* mobile glitch at bottom of subm det on iPhone 5

* mobiliity tweaks

* restore submission details url

* add disqus to submission details (#1358)

* add disqus to submission details
* use submission, not proposal, title

* web3connect/burnerwallet (#1353)

* forgot to commit package.json

* validate for invalid datetime formatting

* add disqus to CompetitionDetails

* xdai support (#1372)

* tweaks to help disqus

* remove disqus from submission details

* nicer formating on submissions heading

* tweak width of winners badge

* tweak redeem button

* fix xdai settings

* fix mainnet connection identifier

* start on high-level caching

* supress build dev errors

* set correct xdai endpoints

* optimize getSubmission

* optimize getCompetitionVotes

* more preparation of queries for caching

* removed redundant code

* upgrade xdao subgraph to v37_3_xdai

* added a comment

* upgrade burnerwallet

* When on xdai network ETH becomes xDAI and GEN becomes xGEN (#1380)

* show only registred daos in xdai network

* new xDao subgraph

* fix tokens.json for production

* lint

* disable new submission button and show tooltip

* add torus web provider

* prevent new submission click when disabled

* undo add Torus

* switch to absolute rep from percentage

* fix compile errors

Co-authored-by: Doug Kent <[email protected]>
Co-authored-by: Shivani <[email protected]>
Co-authored-by: Tibet Sprague <[email protected]>

* Optimize competition (#1407)

* set client t0 0.2.60

* from 22 to 13 requests on competitiondetails page

* fix lint errors

* fix green thumbs when no account (#1409)

* remove semicolon (#1411)

* fix layout of proposal summary card (#1410)

* udpate changelog

* Tweaks (#1412)

* update endpoint to v38_0

* make sure xdai is configured with production settings

* set minum rep reward to 1 WEI (as a workaround)

* fix typoe

* fix lint errors

Co-authored-by: Tibet Sprague <[email protected]>
Co-authored-by: Doug Kent <[email protected]>
Co-authored-by: Jordan Ellis <[email protected]>
Co-authored-by: Shivani <[email protected]>
@leviadam leviadam deleted the web3connect/burnerwallet branch February 16, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants