Fix #132 - get $file before trying to check it.

danmarsden · May 1, 2024 · 1e385a8 · 1e385a8
1 parent 1243d4c
commit 1e385a8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib.php b/lib.php
@@ -451,7 +451,8 @@ function dialogue_pluginfile($course, $cm, $context, $filearea, $args, $forcedow
     $fs = get_file_storage();
     $relativepath = implode('/', $args);
     $fullpath = "/$context->id/mod_dialogue/$filearea/$itemid/$relativepath";
-    if (!$file = $fs->get_file_by_hash(sha1($fullpath)) || $file->is_directory()) {
+    $file = $fs->get_file_by_hash(sha1($fullpath));
+    if (!$file || $file->is_directory()) {
         return false;
     }