-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made it possible to create a TokenList
from a buffer
#347
Conversation
Still need to integrate/test it with #261 to make sure it does not introduce any issues. It is already actively used by |
Some tests are still failing - will investigate. |
The tests failing are the ones with binary characters in the string. We need to add an additional |
StdStringStream
which reads from a std::string
TokenList
from a abuffer
TokenList
from a abufferTokenList
from a buffer
71a7916
to
32f1606
Compare
I changed it from a The tests pass but it produces valgrind failures in #261. |
32f1606
to
1895980
Compare
The issue has been fixed - see https://github.com/danmar/simplecpp/actions/runs/8484373804/job/23247192053?pr=261. |
TokenList
from a bufferTokenList
from a buffer
I will provide a downstream PR which shows this is working within Cppcheck. We should also do the (planned) release before merging this. |
@firewave would you like that I release simplecpp now or do you have some more fixes..? |
} | ||
|
||
virtual int get() OVERRIDE { | ||
if (pos >= size) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These checks are still a hot spot. No idea if there is a way to implement this in a more performant way.
Here is the downstream PR using char buffers instead of streams: danmar/cppcheck#6379. |
Ready for review since the downstream PR passes all tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@firewave you should have gotten an invite for this project. I hope you can merge.. |
@danmar Thanks. |
No description provided.