Set nginx logs to stdout and configure a ecs task role

danieltrolezi · Sep 23, 2024 · e7f0205 · e7f0205
1 parent f74c735
commit e7f0205
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -62,6 +62,7 @@ jobs:
     - name: Update ECS task definition
       run: |
         sed -i 's|<ECS_TASK_EXEC_ROLE>|${{ secrets.ECS_TASK_EXEC_ROLE }}|' ./ecs/deployment-task.json
+        sed -i 's|<ECS_TASK_ROLE>|${{ secrets.ECS_TASK_ROLE }}|' ./ecs/deployment-task.json
         sed -i 's|<ECS_SERVICE_NAME>|${{ vars.ECS_SERVICE_NAME }}|' ./ecs/deployment-task.json
         sed -i 's|<SSM_NAMESPACE>|${{ secrets.SSM_NAMESPACE }}|' ./ecs/deployment-task.json
         sed -i 's|<IMAGE_OCTANE>|${{ secrets.ECR_REPOSITORY_URI }}:latest-octane|' ./ecs/deployment-task.json

diff --git a/docker/nginx/default.conf b/docker/nginx/default.conf
@@ -29,8 +29,8 @@ server {
     location = /favicon.ico { access_log off; log_not_found off; }
     location = /robots.txt  { access_log off; log_not_found off; }
 
-    access_log off;
-    error_log  /var/log/nginx/gamewatch.log error;
+    access_log /dev/stdout;
+    error_log /dev/stderr;
 
     error_page 404 /index.php;
 

diff --git a/ecs/deployment-task.json b/ecs/deployment-task.json
@@ -1,6 +1,10 @@
 {
-  "executionRoleArn": "<ECS_TASK_EXEC_ROLE>",
   "family": "<ECS_SERVICE_NAME>-task",
+  "executionRoleArn": "<ECS_TASK_EXEC_ROLE>",
+  "taskRoleArn": "<ECS_TASK_ROLE>",
+  "requiresCompatibilities": ["EC2"],
+  "cpu": "256",
+  "memory": "512",
   "networkMode": "bridge",
   "containerDefinitions": [
     {
@@ -183,8 +187,5 @@
         }
       }
     }
-  ],
-  "requiresCompatibilities": ["EC2"],
-  "cpu": "256",
-  "memory": "512"
+  ]
 }