Optimise memory allocations in HtmlRenderer
.
#695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly done by avoiding creating additional
StringBuilder
s and writing direct to theTextWriter
where possible. WhereStringBuilder
s are still needed, they're pooled and reusedSaves on the amount of allocated memory and time paused for GC.
I haven't measured a huge improvement in end to end report generation (maybe a second, but hard to say if that's within run to run variance), however reduction in allocations helps and this change does have measurable impacts when combined with my next PR.
Below are the perfview Results with my playground - built on top of the app from #691 with an an additional call to
ReportGenerator.GenerateReport
.Before
After