TASK: Improve code quality

daniellienert · Mar 6, 2020 · cba174c · cba174c
1 parent e4a8726
commit cba174c
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 9 deletions.
diff --git a/Classes/AssetSource/UnsplashAssetProxyQuery.php b/Classes/AssetSource/UnsplashAssetProxyQuery.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 namespace DL\AssetSource\Unsplash\AssetSource;
 
 /*
@@ -114,9 +115,10 @@ public function execute(): AssetProxyQueryResultInterface
 
     /**
      * @return int
+     * @throws \Exception
      */
     public function count(): int
     {
-        throw new \Exception(__METHOD__ . ' is not yet implemented');
+        return $this->execute()->count();
     }
 }
diff --git a/Classes/AssetSource/UnsplashAssetProxyQueryResult.php b/Classes/AssetSource/UnsplashAssetProxyQueryResult.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 namespace DL\AssetSource\Unsplash\AssetSource;
 
 /*
@@ -91,11 +92,11 @@ public function current()
         /** @var Photo $photo */
         $photo = $this->unsplashQueryResultIterator->current();
 
-        if($photo instanceof Photo) {
+        if ($photo instanceof Photo) {
             return new UnsplashAssetProxy($photo, $this->assetSource);
-        } else {
-            return null;
         }
+
+        return null;
     }
 
     /**

diff --git a/Classes/AssetSource/UnsplashAssetProxyRepository.php b/Classes/AssetSource/UnsplashAssetProxyRepository.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 namespace DL\AssetSource\Unsplash\AssetSource;
 
 /*
@@ -55,6 +56,7 @@ public function filterByType(AssetTypeFilter $assetType = null): void
     /**
      * @return AssetProxyQueryResultInterface
      * @throws AssetSourceConnectionExceptionInterface
+     * @throws \Exception
      */
     public function findAll(): AssetProxyQueryResultInterface
     {
@@ -78,6 +80,7 @@ public function findBySearchTerm(string $searchTerm): AssetProxyQueryResultInter
     /**
      * @param Tag $tag
      * @return AssetProxyQueryResultInterface
+     * @throws \Exception
      */
     public function findByTag(Tag $tag): AssetProxyQueryResultInterface
     {
@@ -86,6 +89,7 @@ public function findByTag(Tag $tag): AssetProxyQueryResultInterface
 
     /**
      * @return AssetProxyQueryResultInterface
+     * @throws \Exception
      */
     public function findUntagged(): AssetProxyQueryResultInterface
     {

diff --git a/Classes/AssetSource/UnsplashAssetSource.php b/Classes/AssetSource/UnsplashAssetSource.php
@@ -1,4 +1,5 @@
 <?php
+declare(strict_types=1);
 namespace DL\AssetSource\Unsplash\AssetSource;
 
 /*

diff --git a/Classes/AssetSource/UnsplashImageSizeInterface.php b/Classes/AssetSource/UnsplashImageSizeInterface.php
@@ -11,9 +11,9 @@
 
 interface UnsplashImageSizeInterface
 {
-    const RAW = 'raw';
-    const FULL = 'full';
-    const REGULAR = 'regular';
-    const SMALL = 'small';
-    const THUMB = 'thumb';
+    public const RAW = 'raw';
+    public const FULL = 'full';
+    public const REGULAR = 'regular';
+    public const SMALL = 'small';
+    public const THUMB = 'thumb';
 }