Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#463) bug fixes with particle mass setting in asteroidwind #478

Merged
merged 2 commits into from
Oct 23, 2023
Merged

(#463) bug fixes with particle mass setting in asteroidwind #478

merged 2 commits into from
Oct 23, 2023

Conversation

danieljprice
Copy link
Owner

@danieljprice danieljprice commented Oct 23, 2023 •
edited
Loading

Type of PR:
Bug fix

Description:
Fix assignment of particle mass in the asteroid wind setup from Trevascus et al. (2021). The particle mass must be set during the setup procedure based on the mean mass injection rate and the desired tmax and number of particles at max.

Fixes #463

Testing:

~/phantom/scripts/writemake.sh asteroidwind > Makefile
./phantomsetup wind
./phantom wind

Did you run the bots? no

Did you update relevant documentation in the docs directory? no

@danieljprice danieljprice merged commit 796c375 into master Oct 23, 2023
177 checks passed
@danieljprice danieljprice deleted the asteroidwind branch October 23, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup asteroidwind not working
1 participant
@danieljprice