Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated travis ci for gradle 5 support #19

Merged
merged 4 commits into from
Feb 28, 2019
Merged

Updated travis ci for gradle 5 support #19

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e035022
Updated travis ci for gradle 5 support
gianluz Feb 18, 2019
3963866
Autocomplete and kotlin multiplatform
gianluz Feb 27, 2019
d2efe90
Omitting gradle last version
gianluz Feb 27, 2019
abbbcfa
Remove not needed maven repos
gianluz Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,29 @@ matrix:
script:
- make install
- danger-kotlin ci
- os: osx
osx_image: xcode10
install:
- curl -s "https://get.sdkman.io" | bash
- source ~/.bash_profile
- sdk install kscript
- sdk install gradle 5.2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the version it should take the latest one, that is the one we most care about probably if we take the brew way

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i always use to use fixed versions, if there is an updated version could break something and we not have any control of that. I think is a good idea use known versions. BTW, with gradle 5 there is some problems on kotlin native.. i'm working on that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, but in this specific case, given we are going to use brew as explained in the article @orta posted here #13 (comment), brew doesn't use versions, this means that if we add gradle as dependency who installs danger-kotlin gets it with the latest version available, then I would suggest to test against the one the people will get

- sdk install kotlin
- npm install -g danger
script:
- make install
- danger-kotlin ci
- os: linux
sudo: required
dist: trusty
install:
- curl -s "https://get.sdkman.io" | bash
- source ~/.bash_profile
- sdk install kscript
- sdk install gradle 5.2.1
- sdk install kotlin
- npm install -g danger
- sudo chmod -R a+rwx /usr/local/
script:
- make install
- danger-kotlin ci