Fix author queries #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was overkill and was using lots of memory Signed-off-by: William Casarin <[email protected]>
This was the only thing that wasn't threadsafe. Add a simple mutex instead of a queue so that polling is quick. This also means we can't really return the internal subscriptions anymore, so we remove that for now until we have a safer interface. Fixes: #55 Signed-off-by: William Casarin <[email protected]>
technically more accurate. we are about to introduce a new type called: ndb_ts_u64_id which would be confusing if we didn't do this Signed-off-by: William Casarin <[email protected]>
because this will make the changes nicer Signed-off-by: William Casarin <[email protected]>
This will be the key used by our note_profile_kind indee Signed-off-by: William Casarin <[email protected]>
This function can be used to check if a db is an index or not. We will use this in future functions that rebuild indices. Signed-off-by: William Casarin <[email protected]>
Closed
We need these for profile queries Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
We should be specifying that we've matched the id here, not authors. Not that this would have any effect.. but still. Signed-off-by: William Casarin <[email protected]>
Signed-off-by: William Casarin <[email protected]>
this avoids a lookup if we dont need it Signed-off-by: William Casarin <[email protected]>
This fixes author queries Fixes: #52 Signed-off-by: William Casarin <[email protected]>
jb55
force-pushed
the
fix-author-queries
branch
from
7d43a29 to
3260fa1
Compare
This was referenced Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes author/profile queries by adding a note_pubkey and note_pubkey_kind index
Fixes: