Minor fixes #43
Merged
Minor fixes #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, the all-in-one line does not work to make objects depend on headers. Signed-off-by: Rusty Russell <[email protected]>
Sure, this format would be nice, but it's not what the code does. Signed-off-by: Rusty Russell <[email protected]>
This will find strings which match the beginning of other strings, which seems wrong. Signed-off-by: Rusty Russell <[email protected]>
|
looks good! thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a massive rework of your cursor routines, but it turned up four problems.
Three are fixed here, the other I'm not so sure of. This line in content_parser.c is completely bogus:
These are not even pointers into the same buffer, so block_size is set to random bignum. Fortunately the code which uses it as a limit doesn't hit the limit...