Refactor reQuery method to return ReQuery object

damms005 · Oct 25, 2024 · 7440680 · 7440680
1 parent 039baf8
commit 7440680
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/Services/PaymentHandlers/BasePaymentHandler.php b/src/Services/PaymentHandlers/BasePaymentHandler.php
@@ -7,6 +7,7 @@
 use Illuminate\Foundation\Auth\User;
 use Damms005\LaravelMultipay\Models\Payment;
 use Damms005\LaravelMultipay\Models\PaymentPlan;
+use Damms005\LaravelMultipay\ValueObjects\ReQuery;
 use Illuminate\Database\Eloquent\Casts\ArrayObject;
 use Damms005\LaravelMultipay\Services\PaymentService;
 use Damms005\LaravelMultipay\Actions\CreateNewPayment;
@@ -228,24 +229,24 @@ protected static function getPaymentDescription(?Payment $payment): array
     /**
      * @see \Damms005\LaravelMultipay\Contracts\PaymentHandlerInterface::reQuery()
      */
-    public function reQueryUnsuccessfulPayment(Payment $unsuccessfulPayment)
+    public function reQueryUnsuccessfulPayment(Payment $unsuccessfulPayment): ?ReQuery
     {
         /** @var PaymentHandlerInterface **/
         $handler = app()->make(PaymentHandlerInterface::class, [$unsuccessfulPayment]);
 
         $reQueryResponse = $handler->reQuery($unsuccessfulPayment);
 
         if ($reQueryResponse == null) {
-            return false;
+            return null;
         }
 
-        $isSuccessFulPayment = boolval($reQueryResponse->payment->refresh()->is_success);
+        $isSuccessful = boolval($reQueryResponse->payment->refresh()->is_success);
 
-        if ($isSuccessFulPayment) {
+        if ($isSuccessful) {
             event(new SuccessfulLaravelMultipayPaymentEvent($reQueryResponse->payment));
         }
 
-        return $isSuccessFulPayment;
+        return $reQueryResponse;
     }
 
     public function paymentCompletionWebhookHandler(Request $request)