Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang format #82

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

lenvm
Copy link
Collaborator

@lenvm lenvm commented Nov 8, 2023

This pull request adds a .clang-format file, and formats all files in this repository (except for files in libraries) according to the .clang-format file.

The pull request also adds a pre-commit configuration file, and a GitHub Action that runs pre-commit with clang-format, such that the formatting is checked upon every push and every pull request.

The pre-commit git hook shall be installed locally by running the command line command pre-commit install, for instance using git-bash, in the location where the .pre-commit-config.yaml file is located.

@lenvm lenvm force-pushed the feature/clang-format branch from 3e7947f to 6b6bf57 Compare November 8, 2023 22:38
Copy link
Owner

@dalathegreat dalathegreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved, merge when you feel ready!

@lenvm
Copy link
Collaborator Author

lenvm commented Nov 10, 2023

Hi @dalathegreat, Only those with write access to this repository can merge pull requests. So I think I cannot merge this PR.

@dalathegreat
Copy link
Owner

I added you as collaborator @lenvm ! Merging this!

@dalathegreat dalathegreat merged commit 2575fcc into dalathegreat:main Nov 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants