Update file naming and macro naming for consistency, add missing notifications for PYLON_CAN and CHADEMO_BATTERY #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenvm
force-pushed
the
feature/naming-consistency
branch
from
6ec6b7c to
a2aaadf
Compare
dalathegreat
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Great improvement!
Btw lenvm, incase you want to join the Discord server, here is an invite link: https://discord.gg/5dyBXtAb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the file names and macros for naming consistency, and it orders macros alphabetically.
Consistency and alphabetical ordering allows easier checking if the code is complete.
Some examples of changes that were made:
CAN_BYD-->BYD_CAN(as all other macros first start with the name of the vendor, followed by the protocol)MODBUS_LUNA2000.cpp-->LUNA2000_MODBUS.cpp(as other filenames start with the name of the vendor, followed by the name of the protocol)By ordering the macros alphabetically, I found that:
PYLON_CANwas missingCHADEMO_BATTERYwas missingBoth these notifications are now added.