Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYD Atto 3: Make startup less prone to throw Events #675

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dalathegreat
Copy link
Owner

What

This PR makes the Atto 3 less likely to throw Events the first seconds on startup

image

Why

Feedback from flying tools video on the Atto 3, which reports CELL DEVIATION and UNDERVOLTAGE as soon as the battery starts.

How

The issue was split into two parts

  • Cell max/min values where updated async during OBD2 polling, causing the min to actually be larger than max for a few seconds. By adding ABS subtraction to compare the diff, we catch this edge case
  • Pack undervoltage on startup. Due to the Datalayer having 370.0V as startup value, which is 10V lower than the Atto 3 minimum voltage (380.0V), we now init the value to 380.1V to avoid false positive events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant