Tesla: Tweak plausable SOC% limits #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newevg
requested changes
Feb 18, 2024
There was a problem hiding this comment.
Incorect MAX/MIN was preventing LFP 108pack from Charging:
//Once cell chemistry is determined, set maximum and minimum total pack voltage safety limits
if (LFP_Chemistry) {
max_voltage = 3880;
min_voltage = 2968;
} else { // NCM/A chemistry
max_voltage = 4030;
min_voltage = 3100;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes a bug where LFP Tesla packs would trigger the SOC% not plausable
Why
Due to the changes in PR #190 , the LFP pack would be just on the limit when it comes to autodetecting SOC% not plausable. LFP has a very flat voltage curve, so the check no longer makes sense for LFP
How
We fix this by lowering the SOC% check, and also raising the voltage requirement.