-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better JSON and Mqtt cleanup #178
Conversation
kharnt0x
commented
Feb 13, 2024
- Add ArduinoJson library, which makes the code a lot nicer. Doesn't seem to impact sketch size much.
- Fixed some divide by int's causing rounding.
- add a unique id to the mqtt stuff (use the hostname of the lily)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer on the eyes, good stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider adding an MQTT transmit INFO event. It's not handled consistently here at the moment. One case is handled with a serial print, two ignore the return value and one assigns the return value to a variable but does nothing with it.