Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better JSON and Mqtt cleanup #178

Merged
merged 11 commits into from
Feb 21, 2024
Merged

Conversation

kharnt0x
Copy link
Contributor

  • Add ArduinoJson library, which makes the code a lot nicer. Doesn't seem to impact sketch size much.
  • Fixed some divide by int's causing rounding.
  • add a unique id to the mqtt stuff (use the hostname of the lily)

Copy link
Collaborator

@Cabooman Cabooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer on the eyes, good stuff

Software/src/devboard/mqtt/mqtt.cpp Outdated Show resolved Hide resolved
Software/src/devboard/mqtt/mqtt.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding an MQTT transmit INFO event. It's not handled consistently here at the moment. One case is handled with a serial print, two ignore the return value and one assigns the return value to a variable but does nothing with it.

Software/src/devboard/mqtt/mqtt.cpp Show resolved Hide resolved
@dalathegreat dalathegreat merged commit 9207db3 into dalathegreat:main Feb 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants