Bugfix: Clear battery events properly #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Latest main + this PR now running on my 30kWh LEAF battery! It feels much safer already, caught a cell undervoltage at -17*C much better than the old software 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
With the new introduction of Events, there are some scenarios that can never be recovered from. This PR fixes recovery for minor things, but keeps the latching for the critical stuff like under/overvoltage.
We also now zero out allowed charge/discharge power for LEAF batteries incase we enter a critical fault state. Previously it was possible to continue operation even though a critical fault was active 😱
Why
To improve safety
How
New info events are added for when battery is full/empty, and latching verified for critical safeties.