Event handling! Unit tests! #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to checkout@v4
…attery-Emulator into feature/event-log
trigger commit
…attery-Emulator into feature/event-log
|
One thing to fix, hopefully soon: The ERROR level has priority over DEBUG, so OTA updates do not change the color to blue at the moment. Will see if I can make a quickfix |
| @@ -12,13 +13,14 @@ int ESP32CAN::CANWriteFrame(const CAN_frame_t* p_frame) { | |||
| tx_ok = (result == 0) ? true : false; | |||
| if (tx_ok == false) { | |||
| Serial.println("CAN failure! Check wires"); | |||
| LEDcolor = 3; | |||
| set_event(EVENT_CAN_FAILURE, 0); | |||
There was a problem hiding this comment.
This CAN failure is not the same as the other ones. This means nobody is acking messages on the bus, wires might be disconnected or termination resistance not good. This is more of a complete CAN failure. The other ones are more battery missing on CAN. We should have separate events for these two
There was a problem hiding this comment.
I can add an event and split RX/TX, no probs
dalathegreat
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Events: More complete event handling, that also handles system reactions and handles event logging to EEPROM
Unit tests: A simple unit test framework.
WHY
Events: Easier to add events and handle events in a more deterministic manner
Unit tests: A way to more easily verify functionality, and use for regression testing
HOW
Events: Centralization of bms_status handling, led_color, event message handling, etc etc., plus an EEPROM log
Unit tests: Adding a header-only unit test framework and unit-test Github Action