Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tesla: Make serialprintout more human readable #159

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

dalathegreat
Copy link
Owner

@dalathegreat dalathegreat commented Feb 6, 2024

What

This PR makes the values shown in the USB printout more human readable, with decimals. Thanks to brennar10 over on the Discord for reporting these bugs!

Why

When users see the USB debug printout after getting a battery up and running, they ofcourse check every value in the output page. If one of the values dont look right, this makes the users worry. This PR fixes that!

How

  • Temperatures are now typecasted to int16 to avoid showing negative values as (6553C is now -1C)
  • RealSOC% now has decimals (663 -> 66.3)
  • "Current output" renamed to "DC/DC 12V current"
  • The charge/discharge values not used by the software are no longer printed

@dalathegreat dalathegreat merged commit aa99f65 into main Feb 7, 2024
34 checks passed
@dalathegreat dalathegreat deleted the bugfix/tesla-values-via-usb branch February 7, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants