BYD CAN: Fix average temperature calculation #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed working by brennar10 🥳 |
matvey83
reviewed
Feb 7, 2024
Comment on lines
+138
to
+139
| temp_min = temperature_min; //Convert from unsigned to signed | ||
| temp_max = temperature_max; |
There was a problem hiding this comment.
oh wow, this can be very confusing. I don't think we should be storing signed values in unsigned ints ever (except perhaps very briefly, if really needed). Can we update the code throughout to make temperature_min and temperature_max signed? And do the cast right as they are assigned, in file for each battery?
Comment on lines
+113
to
+114
| static int16_t temp_min = 0; | ||
| static int16_t temp_max = 0; |
There was a problem hiding this comment.
Instead of adding these 2 variables, I'd prefer we make temperature_min and temperature_max signed. (I know it will be more work but having 2 sets of variables for same data is a bit confusing and redundant).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
User brennar10 noticed a bug in the temperature calculation when using BYD CAN. When values go negative, there is a risk that the signed bit is lost during the calculation, causing temperature to appear incorrect
Why
How
The bug is fixed by converting the uint16 values to local int16 values before performing any calculations.