Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tesla: Improve accuracy on temperature value #147

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Tesla: Improve accuracy on temperature value #147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a52b37
Tesla: Improve accuracy on temperature
dalathegreat Jan 28, 2024
7f3c6ad
Init to 0, update comment
dalathegreat Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions Software/src/battery/TESLA-MODEL-3-BATTERY.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ static uint16_t volts = 0; // V
static int16_t amps = 0; // A
static int16_t power = 0; // W
static uint16_t raw_amps = 0; // A
static int16_t max_temp = 6; // C*
static int16_t min_temp = 5; // C*
static int16_t max_temp = 60; // C*
static int16_t min_temp = 50; // C*
dalathegreat marked this conversation as resolved.
Show resolved Hide resolved
static uint16_t energy_buffer = 0;
static uint16_t energy_to_charge_complete = 0;
static uint16_t expected_energy_remaining = 0;
Expand Down Expand Up @@ -209,10 +209,8 @@ void update_values_tesla_model_3_battery() { //This function maps all the value
power = ((volts / 10) * amps);
stat_batt_power = convert2unsignedInt16(power);

min_temp = (min_temp * 10);
temperature_min = convert2unsignedInt16(min_temp);

max_temp = (max_temp * 10);
temperature_max = convert2unsignedInt16(max_temp);

cell_max_voltage = cell_max_v;
Expand Down Expand Up @@ -443,11 +441,8 @@ void receive_can_tesla_model_3_battery(CAN_frame_t rx_frame) {
}
if (mux == 0) //Temperature sensors
{
temp = rx_frame.data.u8[2];
max_temp = (temp * 0.5) - 40; //in celcius, Example 24

temp = rx_frame.data.u8[3];
min_temp = (temp * 0.5) - 40; //in celcius , Example 24
max_temp = (rx_frame.data.u8[2] * 5) - 400; //40.0*C offset, value for instance 85 = 8.5*C
min_temp = (rx_frame.data.u8[3] * 5) - 400; //40.0*C offset, value for instance 85 = 8.5*C
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment is needed to explain the reason for 5 multiplier and 40 degree offset.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment updated in 7f3c6ad

}
break;
case 0x2d2:
Expand Down
Loading