Bugfix/stable ota #127
Merged
Bugfix/stable ota #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalathegreat
approved these changes
Jan 7, 2024
| @@ -316,6 +316,7 @@ String processor(const String& var) { | |||
| void onOTAStart() { | |||
| // Log when OTA has started | |||
| Serial.println("OTA update started!"); | |||
| ESP32Can.CANStop(); | |||
There was a problem hiding this comment.
Very good that Modbus RTU can stay running! The BYD Modbus RTU protocol takes the bms_status value, no other protocol so far is interested in the update status. So this solution is approved! ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Unstable OTA update in live setting
Description
OTA updates work well when not connected to RS485/CAN
Root cause
The CAN functionality is the likely culprit from testing outcomes. Likely, the CAN ISR messes with the OTA routine
Solution
Disabling the CAN peripheral at OTA-start seems to do the trick in a limited testing setup. Disabling the interrupt could also work but this is easy and enough