Tesla: Fix power W calculation #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forcing this as merged, due to being tested in the Issue it was spawned from! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Noticed by @MarkoBolt that the stat_bat_power variable is not formatted correctly. This affects all inverters getting wrong values, and also the webserver will show wrong values.
Why
See how the W is shows as -21313W instead of −8685W
After the fix is applied:
How
This PR fixes the calculation of the value. It is tricky since the signed16 value should be put in an unsigned register (due to legacy modbus reasons)