Revert "Add ramped charge value for Tesla"

dalathegreat · Nov 22, 2023 · 0af0c1f · 0af0c1f
1 parent 375d3a8
commit 0af0c1f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 19 deletions.
diff --git a/Software/src/battery/TESLA-MODEL-3-BATTERY.cpp b/Software/src/battery/TESLA-MODEL-3-BATTERY.cpp
@@ -26,6 +26,7 @@ CAN_frame_t TESLA_221_2 = {
     .MsgID = 0x221,
     .data = {0x61, 0x15, 0x01, 0x00, 0x00, 0x00, 0x20, 0xBA}};  //Contactor Frame 221 - hv_up_for_drive
 
+static uint32_t temporaryvariable = 0;
 static uint32_t total_discharge = 0;
 static uint32_t total_charge = 0;
 static uint16_t volts = 0;     // V
@@ -155,8 +156,8 @@ static const char* hvilStatusState[] = {"NOT OK",
 #define MIN_CELL_VOLTAGE_NCA_NCM 2950   //Battery is put into emergency stop if one cell goes below this value
 #define MAX_CELL_DEVIATION_NCA_NCM 500  //LED turns yellow on the board if mv delta exceeds this value
 
-#define MAX_CELL_VOLTAGE_LFP 3500   //Battery is put into emergency stop if one cell goes over this value
-#define MIN_CELL_VOLTAGE_LFP 2800   //Battery is put into emergency stop if one cell goes below this value
+#define MAX_CELL_VOLTAGE_LFP 3450   //Battery is put into emergency stop if one cell goes over this value
+#define MIN_CELL_VOLTAGE_LFP 2800   //Battery is put into emergency stop if one cell goes over this value
 #define MAX_CELL_DEVIATION_LFP 150  //LED turns yellow on the board if mv delta exceeds this value
 
 void update_values_tesla_model_3_battery() {  //This function maps all the values fetched via CAN to the correct parameters used for modbus
@@ -185,22 +186,19 @@ void update_values_tesla_model_3_battery() {  //This function maps all the value
 
   remaining_capacity_Wh = (expected_energy_remaining * 100);  //Scale up 60.3kWh -> 60300Wh
 
-  // Define the allowed discharge power
-  max_target_discharge_power = (max_discharge_current * volts);
-  // Cap the allowed discharge power if battery is empty, or discharge power is higher than the maximum discharge power allowed
-  if (SOC == 0) {
-    max_target_discharge_power = 0;
-  } else if (max_target_discharge_power > MAXDISCHARGEPOWERALLOWED) {
-    max_target_discharge_power = MAXDISCHARGEPOWERALLOWED;
+  //Calculate the allowed discharge power, cap it if it gets too large
+  temporaryvariable = (max_discharge_current * volts);
+  if (temporaryvariable > 60000) {
+    max_target_discharge_power = 60000;
+  } else {
+    max_target_discharge_power = temporaryvariable;
   }
 
   //The allowed charge power behaves strangely. We instead estimate this value
-  if (SOC == 10000) {  // When scaled SOC is 100%, set allowed charge power to 0
-    max_target_charge_power = 0;
-  } else if (soc_vi > 950) {  // When real SOC is between 95-99.99%, ramp the value between Max<->0
-    max_target_charge_power = MAXCHARGEPOWERALLOWED * (1 - (soc_vi - 950) / 50.0);
-  } else {  // No limits, max charging power allowed
-    max_target_charge_power = MAXCHARGEPOWERALLOWED;
+  if (SOC == 10000) {
+    max_target_charge_power = 0;  //When battery is 100% full, set allowed charge W to 0
+  } else {
+    max_target_charge_power = 15000;  //Otherwise we can push 15kW into the pack!
   }
 
   stat_batt_power = (volts * amps);  //TODO: check if scaling is OK

diff --git a/Software/src/battery/TESLA-MODEL-3-BATTERY.h b/Software/src/battery/TESLA-MODEL-3-BATTERY.h
@@ -7,10 +7,7 @@
 
 #define ABSOLUTE_MAX_VOLTAGE \
   4030  // 403.0V,if battery voltage goes over this, charging is not possible (goes into forced discharge)
-#define ABSOLUTE_MIN_VOLTAGE 2450    // 245.0V if battery voltage goes under this, discharging further is disabled
-#define MAXCHARGEPOWERALLOWED 15000  // 15000W we use a define since the value supplied by Tesla is always 0
-#define MAXDISCHARGEPOWERALLOWED \
-  60000  // 60000W we need to cap this value to max 60kW, most inverters overflow otherwise
+#define ABSOLUTE_MIN_VOLTAGE 2450  // 245.0V if battery voltage goes under this, discharging further is disabled
 
 // These parameters need to be mapped for the Inverter
 extern uint16_t SOC;