Make CookieSpecs/STANDARD the default cookie spec #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasoning --------- The Apache HTTP Client documentation has this to say about the DEFAULT cookie spec: "This policy will be deprecated in favor of the standard (RFC 6265 compliant) implementation in the next minor release of HttpClient." (https://hc.apache.org/httpcomponents-client-ga/tutorial/html/statemgmt.html) The same document then states: "It is strongly recommended to use either Standard or Standard strict policy in new applications." This change makes CookieSpecs/STANDARD the default for the get-cookie-policy multimethod.
|
Tests run through, but I think there are no tests for the cookie spec. I don't feel confident enough to write one myself. |
|
Based on what I've read from the upstream documentation, I think this would apply to the minor version For versions However, if/when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
The Apache HTTP Client documentation has this to say about the DEFAULT
cookie spec:
"This policy will be deprecated in favor of the standard (RFC 6265
compliant) implementation in the next minor release of HttpClient."
(https://hc.apache.org/httpcomponents-client-ga/tutorial/html/statemgmt.html)
The same document then states: "It is strongly recommended to use
either Standard or Standard strict policy in new applications."
This change makes CookieSpecs/STANDARD the default for the
get-cookie-policy multimethod.