Add :async-future as an option for async request processing #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
reviewed
Sep 5, 2019
src/clj_http/client.clj
Outdated
| [req [respond raise]] | ||
| (if (opt req :async) | ||
| [req & [respond raise]] | ||
| {:pre [(not (and (:async req) (:async-future req)))]} |
There was a problem hiding this comment.
These should use (opt req :async) and (opt req :async-future) so they support the optional ? suffix
src/clj_http/client.clj
Outdated
| (opt req :async-future) | ||
| (let [basic-future (org.apache.http.concurrent.BasicFuture. nil)] | ||
| (request (-> req | ||
| (dissoc :async-future) |
There was a problem hiding this comment.
In order to avoid having multiple options I think this should be:
Suggested change
| (dissoc :async-future) | |
| (dissoc :async :async? :async-future :async-future?) |
Sorry for the delay, I've taken your suggestions -- it is ready for review now :) |
|
One thing I really don't like about the approach here is that there is no way to generalize this functionality to For that reason, I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #512.
Notes for Reviwer:
I chose to add a separate option
:async-futureinstead of changing the existing:asyncimplementation to avoid breaking API changes.