#309 Adjust :uri to comply with RFC2396 #501
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add :path to replace the existing intention of :uri. Fix tests involving :uri.
get-url-encoded-uri now accepts a url string instead of java.net.URL and instead of passing through from URL to URI, it goes straight through URI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #309
:uriis now the url-encoded full url as discussed in the issue.It is being run through the java.net.URI constructor after being url-encoded since the URI class implements the spec.
:pathhas been added to replace the previous usage of :uri for consumers of existing functionality.Existing tests have been adjusted.
This is a breaking change fit for 4.x as it changes the meaning of
:urifor existing consumers.