This repository has been archived by the owner on May 16, 2022. It is now read-only.
Improve support for photo links #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies setup on systems where /usr/bin/python is still python2
Also cleans up the regex a bit.
|
This looks good to me so far from my testing, but I need to tweak it a bit to make it pick up url encoded endings (ie using /photo/2 or /2 on the end of a twitter link with encoded endings, IE) |
|
in a related issue I REALLY need to learn how regex works 🥲 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the change I suggested at https://github.com/robinuniverse/TwitFix/issues/44#issuecomment-1065567675
Additionally cleans up the matching a bit, tweaks the readme, fixes a missing entry in requirements.txt, and simplifies local testing a little.
I haven't fully tested this end-to-end, as I don't have twitter API access set up, but everything seems to behave as expected in the logs.