Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate goerli to sepolia #682

Merged
merged 1 commit into from
Feb 10, 2024
Merged

chore: migrate goerli to sepolia #682

merged 1 commit into from
Feb 10, 2024

Conversation

dcposch
Copy link
Member

@dcposch dcposch commented Feb 7, 2024

No description provided.

Copy link

socket-security bot commented Feb 7, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@daimo/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +891 339 MB dcposch

🚮 Removed packages: npm/@daimo/[email protected]

View full report↗︎

@@ -144,7 +140,7 @@ function NoteDisplayInner({
const nonce = useMemo(() => new DaimoNonce(nonceMetadata), [ephemeralOwner]);

const isV2RecipientClaim =
noteStatus.contractAddress === daimoEphemeralNotesV2Address &&
noteStatus.link.type === "notev2" &&
Copy link
Member

@nalinbhardwaj nalinbhardwaj Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 these are actually not equivalent (there were two migrations contract v1 > v2 and link v1 > v2 independently) but its fine to assume no one could have been in the middle.

@@ -244,22 +247,24 @@ async function linkStatusToAction(
urlHash
);

if (contractAddress === daimoEphemeralNotesV2Address) {
if (linkStatus.link.type === "notev2") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

const hash = bundlerClient.getOpHash(op, vc.publicClient);
console.log(`NOT sending userOp. Hash: ${hash}`);
return hash;
// return bundlerClient.sendUserOp(op, vc);
Copy link
Member

@nalinbhardwaj nalinbhardwaj Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flagging TODO

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the scratchpad 🤷‍♂️

Copy link
Member

@nalinbhardwaj nalinbhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm broadly, feel free to merge if everything works so can rebase other contracts and start testing on sepolia

@@ -27,8 +27,7 @@ contract DaimoEphemeralNotes {
event NoteRedeemed(Note note, address redeemer);

// Stablecoin token to use for notes, or 0x0 for USDC.
// This allows us to CREATE2-deploy this contract at the same address
// on Base and Base Goerli.
// This allows us to CREATE2-deploy at the same address on different chains.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this edit changes the create2 address no, would revert unless you're migrating deployment

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, reverted

@dcposch dcposch force-pushed the dc/sepolia branch 2 times, most recently from c3223bd to 9a1b1da Compare February 10, 2024 08:33
@dcposch dcposch merged commit 890e511 into master Feb 10, 2024
4 of 5 checks passed
This was referenced Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants