-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate goerli to sepolia #682
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@daimo/[email protected] |
@@ -144,7 +140,7 @@ function NoteDisplayInner({ | |||
const nonce = useMemo(() => new DaimoNonce(nonceMetadata), [ephemeralOwner]); | |||
|
|||
const isV2RecipientClaim = | |||
noteStatus.contractAddress === daimoEphemeralNotesV2Address && | |||
noteStatus.link.type === "notev2" && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 these are actually not equivalent (there were two migrations contract v1 > v2 and link v1 > v2 independently) but its fine to assume no one could have been in the middle.
@@ -244,22 +247,24 @@ async function linkStatusToAction( | |||
urlHash | |||
); | |||
|
|||
if (contractAddress === daimoEphemeralNotesV2Address) { | |||
if (linkStatus.link.type === "notev2") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
const hash = bundlerClient.getOpHash(op, vc.publicClient); | ||
console.log(`NOT sending userOp. Hash: ${hash}`); | ||
return hash; | ||
// return bundlerClient.sendUserOp(op, vc); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flagging TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's the scratchpad 🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm broadly, feel free to merge if everything works so can rebase other contracts and start testing on sepolia
@@ -27,8 +27,7 @@ contract DaimoEphemeralNotes { | |||
event NoteRedeemed(Note note, address redeemer); | |||
|
|||
// Stablecoin token to use for notes, or 0x0 for USDC. | |||
// This allows us to CREATE2-deploy this contract at the same address | |||
// on Base and Base Goerli. | |||
// This allows us to CREATE2-deploy at the same address on different chains. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this edit changes the create2 address no, would revert unless you're migrating deployment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call, reverted
c3223bd
to
9a1b1da
Compare
No description provided.